-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
386: revise base64url description #387
Conversation
This closes #386. @jmarshall your review here is welcome. |
🤷 I think it's good that the introductory paragraph uses familiar terms, while steps 1–3 are more precise. So I would just delete /URL/ leaving But it's all a bit bikesheddy, so whatever is good. |
Yeesh, how on earth did the readthedocs run for the first commit succeed? 😄 Has there been a massive readthedocs update in the last fourteen hours? |
I think |
Yep. Looks like Sphinx 4.x would be insulated against the change BTW: sphinx-doc/sphinx@e5c905c. |
@larrybabb and/or @andreasprlic you good with these changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay.
No description provided.